Add parameters for S3 credentials #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havok2063
reviewed
Jul 30, 2024
| @@ -38,7 +45,7 @@ def _get_cloud_http(s3_uri: Union[str, S3Path], verbose: bool = False) -> str: | |||
| print(f'Attempting to access private S3 bucket: {s3_path.bucket}') | |||
|
|
|||
| # create file system and get URL of file | |||
| fs = s3fs.S3FileSystem(anon=is_anon) | |||
| fs = s3fs.S3FileSystem(anon=is_anon, key=key, secret=secret, token=token) | |||
There was a problem hiding this comment.
Do we want a check here to make sure one of the access inputs is set when is_anon is False?
There was a problem hiding this comment.
For certain cases, a credential may not be needed. For instance, RSP doesn't need to pass credentials because the environment has direct access to the private S3 bucket.
There was a problem hiding this comment.
that makes sense, thanks!
havok2063
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameters to
asdf_cutthat allow the user to provide an S3 access key (key), secret access key (secret), or security token (token). These should only have an impact for private S3 buckets (is_anon = False), so I left in the logic to determine if a bucket is public or private.