Bugfix for implementation and test for invalid file type input in make_cube() #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havok2063
previously approved these changes
Sep 24, 2024
astrocut/tests/test_make_cube.py
Outdated
Comment on lines
191
to
194
| # Should raise a Value Error due to incorrect file type | ||
| with pytest.raises(ValueError) as error_msg: | ||
| cube_maker.make_cube(manifest["Local Path"]) | ||
| cube_maker.make_cube(ffi_files) | ||
| assert value_error in str(error_msg.value) |
There was a problem hiding this comment.
pytest.raises has a match keyword that takes a string, or regex pattern to match against the raised error message, simplifying this usage slightly. For example:
with pytest.raises(ValueError, match=value_error):
cube_maker.make_cube(ffi_files)
Sometimes it's finicky about exact strings versus a "regex" string. In those cases I usually give it a sub-string of the full error message.
There was a problem hiding this comment.
Good to know, thank you! Just made that change.
havok2063
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test environment using dev dependencies has been failing due to a recent change in Astroquery. Because Astroquery no longer allows users to get products for TESS/TICA FFIs,
test_make_cube.py::test_invalid_inputswas no longer passing. I modified the test to use thecreate_test_ffisfunction rather than Astroquery.While doing this, I also discovered a small bug in the
CubeFactoryimplementation when TICA files are passed in. I moved the try-catch block inCubeFactory._configure_cubeto catch and output the error the first time that access toffi_data[1]is attempted.