Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-837: Invalid Reference to Pyraf #1726

Conversation

s-goldman
Copy link
Collaborator

@s-goldman s-goldman commented Jan 29, 2024

Resolves HLA-837

This PR changes outdated mentions of pyraf to python. It also remove several outdated comments.

This PR also adds a couple log files to the .gitignore file that tend to be accidentally added to commits.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR

Copy link
Collaborator

@mdlpstsci mdlpstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference to Python should be consistent in the text: Python or python. Please see comments in text.

@s-goldman s-goldman requested a review from mdlpstsci January 30, 2024 15:55
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18de0f5) 31.06% compared to head (27bb8d3) 31.23%.

❗ Current head 27bb8d3 differs from pull request most recent head d366768. Consider uploading reports for the commit d366768 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1726      +/-   ##
==========================================
+ Coverage   31.06%   31.23%   +0.16%     
==========================================
  Files         159      159              
  Lines       35102    35102              
==========================================
+ Hits        10905    10964      +59     
+ Misses      24197    24138      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mdlpstsci mdlpstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many good updates and clean-up of cruft! Once most of the dust has settled, we may have to sweep through the docs again, but it will be soooooo much easier!

@s-goldman s-goldman merged commit 1941e07 into spacetelescope:master Jan 31, 2024
14 of 15 checks passed
@s-goldman s-goldman deleted the hla-837_invalid_reference_to_pyraf_1_29_24 branch January 31, 2024 22:47
mdlpstsci pushed a commit to mdlpstsci/drizzlepac that referenced this pull request Feb 21, 2024
Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants