-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLA-1190: New installation instructions and small text changes #1727
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1727 +/- ##
=======================================
Coverage 31.14% 31.14%
=======================================
Files 159 159
Lines 35102 35102
=======================================
Hits 10933 10933
Misses 24169 24169 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these changes look fine, but there needs to be some rewording as I noted in a comment. I will write up a few sentences momentarily.
@s-goldman Drizzlepac has evolved over time from not only being
where PPPP = 4-digit projection cell number runastrodriz.py is the module to control operation of AstroDrizzle to runsinglehap.py is the module which controls the single visit mosaic runmultihap.py is the module which controls the single visit mosaic You can discuss "AstroDrizzle" as being a fundamental module which is the basis for all of the above code. |
I also just got a reply from Jenn on the driz_updates slack channel that we should remove the stuff about HAP and move it to the HAP API (which also needs an intro) and I think she is right. If it sounds good to you, I will use this for the HAP API intro and create another drizzlepac interface intro just for runastrodriz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After our discussion I am willing to approve this PR even though I do not think the SVM and MVM discussion should fall under the MAST category. These are calibration pipeline produced products and deserve the same level of discussion given to the use of "drizzlepac (runastrodriz)". Having said this, I think is fine to wait until the documentation is further fleshed out and to read all the docs for a high-level view. In any case, kudos on your patience and thoroughness!
…telescope#1727) Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>
Resolves HLA-1190
This PR updates the installation instructions and makes several changes related to the recent readthedocs restructuring.
Checklist for maintainers
CHANGELOG.rst
within the relevant release sectionHow to run regression tests on a PR
Jenkins test