Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a multi-dimensional PixelFrame #461

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cadair
Copy link
Collaborator

@Cadair Cadair commented Jun 23, 2023

I often find myself doing cf.CoordinateFrame(3, ["PIXEL", "PIXEL", "PIXEL"], unit=[u.pix, u.pix, u.pix], ...) to generate an input frame to a single stage "pixel to world" type WCS.

Having a shortcut, designed to be an input frame where you aren't going to have a compound frame or anything as input, like this PixelFrame would let you do PixelFrame(3) and get the same result.

I do think that Frame2D feels somewhat like a special case of this new PixelFrame, but not sure if it's worth deprecating Frame2D or not.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.66%. Comparing base (8a28efc) to head (2d6ee0d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
gwcs/coordinate_frames.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
+ Coverage   87.58%   87.66%   +0.08%     
==========================================
  Files          22       22              
  Lines        3955     3908      -47     
==========================================
- Hits         3464     3426      -38     
+ Misses        491      482       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant