Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to rename default branch to main #501

Closed
wants to merge 2 commits into from

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jul 5, 2024

This PR renames some branch references to main to allow renaming the default branch to main.

I found only 1 use of the current default branch in asdf-wcs-schemas. See asdf-format/asdf-wcs-schemas#64

The following process should work:

  • merge the above asdf-wcs-schemas PR
  • rename the gwcs default branch to main
  • merge this PR

@@ -14,7 +14,7 @@ spectral wavelength) is crucial to relating astronomical data to the phenomena t
other types of data often come encoded with information that describes this mapping – this is referred
to as the ‘World Coordinate System’ or WCS. The term WCS is often used to refer specifically
to the most widely used 'FITS implementation of WCS', but here unless specified WCS refers to
the broader concept of relating pixel ⟷ world. (See the discussion in `APE14 <https://github.com/astropy/astropy-APEs/blob/master/APE14.rst#backgroundterminology>`__
the broader concept of relating pixel ⟷ world. (See the discussion in `APE14 <https://github.com/astropy/astropy-APEs/blob/main/APE14.rst#backgroundterminology>`__
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo has renamed the default branch to "main" github is still handling the redirect so both the old and new links point to the same location.

@braingram
Copy link
Collaborator Author

I added a changelog for this but I'm not sure if it's necessary (as it's more of a developer facing and not user facing change). Let me know if I should drop the changelog entry.

@braingram braingram changed the title rename branch references to main Prepare to rename default branch to main Jul 5, 2024
@braingram braingram marked this pull request as ready for review July 5, 2024 20:31
@braingram braingram requested a review from a team as a code owner July 5, 2024 20:31
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.26%. Comparing base (eb9d316) to head (d42bce2).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
- Coverage   87.28%   87.26%   -0.03%     
==========================================
  Files          22       21       -1     
  Lines        3821     3815       -6     
==========================================
- Hits         3335     3329       -6     
  Misses        486      486              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@braingram braingram closed this Nov 18, 2024
@braingram braingram deleted the default_main branch November 18, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant