Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Functions in mast_api_psf Module #335

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mrevalski
Copy link
Collaborator

This request includes minor updates to the mast_api_psf.py module and the corresponding function calls throughout the notebook. These changes were made to match the final version of these functions as they appear in the published version of the download_psf_cutouts.ipynb produced by Fred Dauphin (@FDauphin), which was revised earlier this year.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@FDauphin FDauphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks pretty good to me. Just two minor typos I found. Also the notebook didn't pass the CI tests so make sure to look at those too and properly address those. Great work 👍🏾

@mrevalski
Copy link
Collaborator Author

Hi @haticekaratay and @dulude, the CI is giving an exit code 143 error. I am able to run the notebook locally without issue, so please let me know if there are any tests I can complete to track down the source of this issue. Thanks for your time and help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants