-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wfss notebooks to not fail CI #175
Merged
haticekaratay
merged 10 commits into
spacetelescope:main
from
camipacifici:update-wfss-old
Oct 18, 2023
Merged
Update wfss notebooks to not fail CI #175
haticekaratay
merged 10 commits into
spacetelescope:main
from
camipacifici:update-wfss-old
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
haticekaratay
had a problem deploying
to
ci_env
October 16, 2023 19:11 — with
GitHub Actions
Failure
haticekaratay
had a problem deploying
to
ci_env
October 16, 2023 19:11 — with
GitHub Actions
Failure
haticekaratay
had a problem deploying
to
ci_env
October 16, 2023 19:11 — with
GitHub Actions
Failure
haticekaratay
had a problem deploying
to
ci_env
October 16, 2023 19:11 — with
GitHub Actions
Failure
haticekaratay
had a problem deploying
to
ci_env
October 16, 2023 19:11 — with
GitHub Actions
Failure
haticekaratay
had a problem deploying
to
ci_env
October 17, 2023 01:48 — with
GitHub Actions
Failure
haticekaratay
had a problem deploying
to
ci_env
October 17, 2023 01:48 — with
GitHub Actions
Failure
haticekaratay
had a problem deploying
to
ci_env
October 17, 2023 01:49 — with
GitHub Actions
Failure
haticekaratay
had a problem deploying
to
ci_env
October 17, 2023 01:49 — with
GitHub Actions
Failure
haticekaratay
had a problem deploying
to
ci_env
October 17, 2023 01:54 — with
GitHub Actions
Failure
haticekaratay
had a problem deploying
to
ci_env
October 17, 2023 19:42 — with
GitHub Actions
Failure
haticekaratay
had a problem deploying
to
ci_env
October 17, 2023 20:14 — with
GitHub Actions
Failure
haticekaratay
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All style errors have been fixed, and I approve it as is since these notebooks are not intended for a technical review.
32 tasks
haticekaratay
added a commit
that referenced
this pull request
Oct 18, 2023
* Update wfss notebooks to not fail CI * Address some of the style errors on the nb 03 * Fix style errors and update read_hdfs5 function * Fix the remaining style errors on the 02 and 03 nb * Some updates to 00 * Fix style errors on the 01 nb * Fix minor style errors on the nb 01 * Address more style errors * Fix remaining style errors * Fix last two style errors --------- Co-authored-by: Camilla Pacifici <[email protected]> Co-authored-by: Hatice Karatay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the requirement file to use the most recent version of the required packages.
This notebook checklist has been made available to us by the the Notebooks For All team.
Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
Visualization descriptions include
All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.