-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notebooks to remove deprecated methods #192
Update notebooks to remove deprecated methods #192
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I wonder if we need something more user-friendly at the helper level for this case (exploring what data exists in the app, rather than just extracting data where you already know the label, etc)? With what exists now, this probably makes sense for the notebook, though. |
The notebook execution failures are due to needing UI interactions to define subsets before running those notebook cells, I assume those tests have never passed. And the pep8 failures appear unrelated to my changes. |
The ifu_optimal notebook is in another PR with edits from Patrick. Maybe Ricky's changes have already been addressed in Patrick's PR. |
ce2698a
to
3253695
Compare
@haticekaratay I fixed the conflicts with main, I think this is good to go now. I left in two updates to Patrick's IFU notebook to better use current API methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Ricky, for your work. A follow-up ticket is created to fix the execution and styles that are out of the scope of this PR.
Recent Jdaviz releases have deprecated (and finally removed) the
app.get_data_from_viewer
,app.get_subsets_from_viewer
, andspecviz.load_spectrum
methods. This PR updates affected notebooks accordingly. I tagged a few relevant folks as reviewers, wasn't sure who all would want to see this.