-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NIRISS WFSS Notebook Examples #214
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This is being reviewed by members of the NIRISS team and @camipacifici before it will be ready to be merged. |
notebooks/NIRISS_WFSS_advanced/01_niriss_wfss_image2_image3.ipynb
Outdated
Show resolved
Hide resolved
notebooks/NIRISS_WFSS_advanced/01_niriss_wfss_image2_image3.ipynb
Outdated
Show resolved
Hide resolved
"tags": [] | ||
}, | ||
"source": [ | ||
"Image3 is where we can make some adjustments to obtain a better output source catalog. The `cal.fits` files will be calibrated into a single combined `i2d.fits` image. More information about the steps performed in the Image3 part of the pipeline can be found in the [Image3 pipeline documentation](https://jwst-pipeline.readthedocs.io/en/latest/jwst/pipeline/calwebb_image3.html).\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be a little more specific about "make some adjustments to obtain a better output source catalog". Maybe say that the notebook will run image3 twice (with the default and with better parameters).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camipacifici it would actually be really helpful if you could add/if you let me know I can add why you chose the parameters you did for source_catalog and tweakreg. I didn't change what you had in there before, and they look better, but I don't actually know all of the secrets. I did update the text above that call to point to some documentation about possible parameters to change (this accidentally was cut and jupyter overwrote the save before I could bring it back).
…really needed for the point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All CI is passing, each notebook runs without issues both independently and in order. Ready to merge!
This notebook checklist has been made available to us by the the Notebooks For All team.
Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
for review; I would like comments on this
All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
Visualization descriptions include
All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.