Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Aperture Photometry: Recalculation breaks after Subset is edited #1443

Closed
Jdaviz-Triage-Bot opened this issue Jul 1, 2022 · 0 comments · Fixed by #1447
Closed

Simple Aperture Photometry: Recalculation breaks after Subset is edited #1443

Jdaviz-Triage-Bot opened this issue Jul 1, 2022 · 0 comments · Fixed by #1447
Labels
bug Something isn't working imviz

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented Jul 1, 2022

Reporter: pllim

As reported in #1409 (review) . Workflow to reproduce:

  1. Calculate aperture photometry as usual.
  2. Now go back to the aperture subset, put it in edit mode, and move it to another star that you know will give a completely different answer.
  3. Press calculate again without touching the aperture dropdown menu in the plugin.
  4. Notice that the Subset info update in the Subset info plugin, but aperture photometry result still same as the old Subset.

This is because the plugin is not listening to subset edit event. @kecnry proposed potential fix at #1409 (comment) . Probably want to add a new unit test to prevent regression too.

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working imviz
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants