BUG: Simple Aperture Photometry plugin to update when Subset updates

[pllim]

Description

This pull request is to ensure Simple Aperture Photometry plugin is aware of Subset that is updated after it is created, if relevant to calculations. Most things will not recalculate until user presses "Calculate" but the background is calculated "live" before the button is pressed. There are 3 dropdowns. The dataset dropdown already triggers all recalculations, so I don't think it is affected but this bug.

This patch fixes the following cases:

1. When aperture is selected, editing the aperture Subset will cause: (a) background to update immediately in "Annulus" mode, and (b) the rest to update when pressing "Calculate".
2. When background is from Subset, editing the background Subset till cause the background to update immediately.

Fixes #1443

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a change log needed? If yes, is it added to CHANGES.rst?
• Is a milestone set?
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[pllim]

Devs, I am not familiar with the edit mode syntax, so please let me know if it is correct to test this way.

Would also be nice if you can tell me how to programmatically control which Subset to put in ReplaceMode.

Thanks!

[kecnry]

To programmatically set the subset in replace mode, you can do something like:

imviz_helper.app.session.edit_subset_mode.edit_subset = [imviz_helper.app.data_collection.subset_groups[0]]

[codecov]

Codecov Report

Merging #1447 (6b8e0b9) into main (050b62d) will decrease coverage by 0.00%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main    #1447      +/-   ##
==========================================
- Coverage   85.16%   85.15%   -0.01%     
==========================================
  Files          91       91              
  Lines        8359     8369      +10     
==========================================
+ Hits         7119     7127       +8     
- Misses       1240     1242       +2     

Impacted Files	Coverage Δ
...imviz/plugins/aper_phot_simple/aper_phot_simple.py	91.83% <81.81%> (-0.36%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050b62d...6b8e0b9. Read the comment docs.

[kecnry]

Confirmed that this fixes the two use-cases explained in the PR description.

Someday I'd like to see this type of logic supported directly in the subset dropdown component, but the implementation here is pretty lightweight as-is, so let's defer that until/unless another plugin needs something similar (basically plugin-callbacks when the underlying data of the selected object changes).