Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markers plugin #1953

Merged
merged 40 commits into from
Mar 16, 2023
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
4b25e16
basic markers plugin implementation
kecnry Feb 11, 2023
985d83b
log info from coords_info mouseover display
kecnry Feb 11, 2023
f114b6e
allow user to select layer used in mouseover/markers
kecnry Feb 14, 2023
dd44098
fix support for creating new viewers in Imviz
kecnry Feb 22, 2023
7ed2239
improved support for mixed viewers
kecnry Feb 23, 2023
77521d5
log wcs unreliability
kecnry Feb 24, 2023
0d573f7
rename table column pixel->index
kecnry Feb 24, 2023
f8b50bd
log viewer reference instead of id
kecnry Feb 24, 2023
fa0d748
revert disabling spectrum locking during zoom/subset tool
kecnry Feb 24, 2023
43423b4
use DatasetMixin instead of LayerMixin
kecnry Feb 24, 2023
21307ce
changelog entry
kecnry Feb 24, 2023
7b94215
clear table info to force defaults on keypress
kecnry Feb 24, 2023
5d819d2
update mouseover test to show cursor info when out of bounds
kecnry Feb 24, 2023
5aa6cba
fix css layout for layer/viewer icon in dropdowns
kecnry Feb 24, 2023
7628ab7
fix viewer reference when None (imviz additional viewers)
kecnry Feb 24, 2023
2a50ebf
fix accessing image value of non-active layer
kecnry Feb 24, 2023
9c7ab45
update Markers plugin docs
kecnry Feb 24, 2023
1be5e0a
expose slice wavelength
kecnry Feb 27, 2023
ede27c5
test coverage
kecnry Mar 1, 2023
ca55478
plugin API docs
kecnry Mar 1, 2023
5fd865a
Apply suggestions from code review
kecnry Mar 6, 2023
79c81f9
fix specviz2d marker in spectrum then spectrum2d
kecnry Mar 6, 2023
7c60ef0
update tests to work with full sky coord precision
kecnry Mar 6, 2023
2a3a894
fallback on exposing cursor information when no valid layer match
kecnry Mar 6, 2023
4d1f3ab
allow selecting the auto-collapsed spectrum in the coords info cycler
kecnry Mar 6, 2023
8052e15
table subcomponent: always show columns in same order
kecnry Mar 7, 2023
8c7bc17
store pixel and axes coordinates separately
kecnry Mar 7, 2023
4fb37db
limit precision shown in UI version of the table
kecnry Mar 7, 2023
19a0667
add helper text for cycling layers
kecnry Mar 7, 2023
1ae221e
improve dictionary comparison in markers test
kecnry Mar 8, 2023
c4fb1a9
only expose pixel/world:unreliable in cubeviz
kecnry Mar 8, 2023
46f3590
fix exposing value for 2d spectrum viewer in specviz2d
kecnry Mar 8, 2023
48b54de
fix mouseover before data loaded in viewer in mosviz
kecnry Mar 8, 2023
6a50534
add value:unreliable and explanation text in docs
kecnry Mar 8, 2023
3aa2ff4
only include spatial subsets in cycler for cubeviz
kecnry Mar 14, 2023
b60bd61
imviz mouseover cycler to only consider image layers
kecnry Mar 14, 2023
f9b46cf
fallback for object-cache
kecnry Mar 14, 2023
1443057
docs updates
kecnry Mar 14, 2023
349f66f
exclude slice for 2d images in cubeviz
kecnry Mar 16, 2023
cf4eb4f
Apply suggestions from code review
kecnry Mar 16, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
log wcs unreliability
kecnry committed Mar 16, 2023

Verified

This commit was signed with the committer’s verified signature.
t3chguy Michael Telatynski
commit 77521d5ee17b5d991ec36cec3ff18c2079aeaee3
6 changes: 5 additions & 1 deletion jdaviz/configs/default/plugins/markers/markers.py
Original file line number Diff line number Diff line change
@@ -13,13 +13,15 @@
'x:unit': '',
'y': np.nan,
'y:unit': '',
'xy:unreliable': False,
'slice': np.nan,
'value': np.nan,
'value:unit': '',
'RA (ICRS)': '',
'DEC (ICRS)': '',
'RA (deg)': np.nan,
'DEC (deg)': np.nan,
'radec:unreliable': False,
'pixel': np.nan}


@@ -49,8 +51,10 @@ def __init__(self, *args, **kwargs):

if self.config in ['imviz', 'cubeviz', 'mosviz']:
kecnry marked this conversation as resolved.
Show resolved Hide resolved
# image viewers
headers += ['RA (ICRS)', 'DEC (ICRS)',
headers += ['xy:unreliable',
'RA (ICRS)', 'DEC (ICRS)',
'RA (deg)', 'DEC (deg)',
'radec:unreliable',
'value', 'value:unit',
'viewer']
if self.config in ['specviz', 'specviz2d', 'mosviz']:
kecnry marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 2 additions & 0 deletions jdaviz/configs/imviz/plugins/coords_info/coords_info.py
Original file line number Diff line number Diff line change
@@ -308,6 +308,7 @@ def _image_viewer_update(self, viewer, x, y):
self._dict['DEC (ICRS)'] = world_dec
self._dict['RA (deg)'] = float(world_ra_deg)
self._dict['DEC (deg)'] = float(world_dec_deg)
self._dict['radec:unreliable'] = unreliable_world
else:
self.row2_title = '\u00A0'
self.row2_text = ""
@@ -322,6 +323,7 @@ def _image_viewer_update(self, viewer, x, y):
self.row1a_title = 'Pixel'
self.row1a_text = (fmt.format(x, y))
self.row1_unreliable = unreliable_pixel
self._dict['xy:unreliable'] = unreliable_pixel

# Extract data values at this position.
# TODO: for now we just use the first visible layer but we should think