Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cubeviz coordinates panel with inaccurate sky coordinates sometimes #2002

Closed
wants to merge 3 commits into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Feb 9, 2023

Description

This pull request is to:

TODO

  • Investigate failure in test_fits_image_hdu_parse_from_file
  • FITS WCS: Is x always RA and y always DEC?
  • Wait to update tests only after this is merged: refactor mouseover coords info display #1976
  • Vet the fix with real data that goes through _parse_jwst_s3d and _parse_esa_s3d, if possible. I do not know where these data are.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

that can be inaccurate for uncert and mask data under certain condition.
@pllim pllim added the bug Something isn't working label Feb 9, 2023
@pllim pllim added this to the 3.4 milestone Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 91.95% // Head: 91.91% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (503f52b) compared to base (434f644).
Patch coverage: 84.78% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2002      +/-   ##
==========================================
- Coverage   91.95%   91.91%   -0.05%     
==========================================
  Files         140      140              
  Lines       15333    15354      +21     
==========================================
+ Hits        14100    14113      +13     
- Misses       1233     1241       +8     
Impacted Files Coverage Δ
...configs/cubeviz/plugins/moment_maps/moment_maps.py 91.46% <62.50%> (-3.21%) ⬇️
jdaviz/configs/cubeviz/plugins/viewers.py 89.30% <73.33%> (-2.53%) ⬇️
...eviz/plugins/moment_maps/tests/test_moment_maps.py 100.00% <100.00%> (ø)
...aviz/configs/cubeviz/plugins/tests/test_parsers.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim
Copy link
Contributor Author

pllim commented Feb 10, 2023

@mcara said this is the wrong approach. I'll step back and investigate the root of this problem upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cubeviz
Projects
None yet
1 participant