Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Remove my_mask from ImvizExample #2641

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 2, 2024

Description

This pull request is to remove my_mask from ImvizExample notebook because it is crashing some other cells. my_mask was originally designed with ImvizDitheredExample in mind and simply copied over to ImvizExample later. It is not critical for typical Imviz operations.

Fixes #2638

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

because it is crashing some other cell.
@pllim pllim added bug Something isn't working imviz trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Jan 2, 2024
@pllim pllim added this to the 3.9 milestone Jan 2, 2024
@github-actions github-actions bot added the documentation Explanation of code and concepts label Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b997fb) 91.52% compared to head (fbaf194) 91.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2641   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         161      161           
  Lines       19989    19989           
=======================================
  Hits        18295    18295           
  Misses       1694     1694           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@pllim pllim merged commit 18a361b into spacetelescope:main Jan 2, 2024
24 of 26 checks passed
@pllim pllim deleted the bye-bye-space-invader-sadface branch January 2, 2024 20:33
@kecnry
Copy link
Member

kecnry commented Jan 2, 2024

Wait, but is there still a bug? Or should we prevent load_regions in this case?

@pllim
Copy link
Contributor Author

pllim commented Jan 2, 2024

is there still a bug?

If you ever want a full size mask on this particular image set, yes. I think it is in the GWCS + glue coordinates translation somewhere.

Is it worth spending time to hunt down? Probably not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Explanation of code and concepts imviz no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Imviz API triggering IndexError from Glue
3 participants