Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix new viewer after image rotation #2677

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jan 26, 2024

Description

This pull request generalizes the logic for adding a new viewer so other configs/viewers that don't use the concept of reference data and wcs-linking (introduced in #2179) do not raise a traceback.

This is a minor change to a feature not-yet-released, so does not need a changelog entry of its own (although we could append the PR number to the image rotation PR if a link between the PRs in GitHub is not sufficient papertrail).

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Jan 26, 2024
@kecnry kecnry added this to the 3.9 milestone Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9414cd8) 90.85% compared to head (27efa68) 90.86%.

Files Patch % Lines
jdaviz/app.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2677   +/-   ##
=======================================
  Coverage   90.85%   90.86%           
=======================================
  Files         162      162           
  Lines       21126    21127    +1     
=======================================
+ Hits        19195    19196    +1     
  Misses       1931     1931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review January 26, 2024 14:56
@kecnry kecnry added the trivial Only needs one approval instead of two label Jan 26, 2024
@pllim pllim added the imviz label Jan 26, 2024
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Thanks!

@pllim
Copy link
Contributor

pllim commented Jan 26, 2024

I'll let you decide if you also want Brett to review. If not, feel free to merge.


if hasattr(viewer, 'reference'):
viewer.state.reference_data = ref_data
if self.config == 'imviz':
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try to generalize this logic instead of hardcoding the config, but not sure its worth it until/unless other configs need this logic? See the commit history to see a failed attempt.

Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible. Thanks!

@kecnry kecnry merged commit e6885df into spacetelescope:main Jan 26, 2024
22 of 23 checks passed
@kecnry kecnry deleted the fix-new-viewer branch January 26, 2024 14:59
gibsongreen pushed a commit to gibsongreen/jdaviz that referenced this pull request Feb 12, 2024
* generalize app _on_new_viewer for non-imviz case
* limit logic block to only run for imviz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imviz no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants