Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #2865 on branch v3.10.x (TST: Upload to codecov as separate job) #2866

Merged
merged 1 commit into from
May 9, 2024
Merged

Backport PR #2865 on branch v3.10.x (TST: Upload to codecov as separate job) #2866

merged 1 commit into from
May 9, 2024

Conversation

meeseeksmachine
Copy link

Backport PR #2865: TST: Upload to codecov as separate job

@lumberbot-app lumberbot-app bot added this to the 3.10.1 milestone May 9, 2024
@lumberbot-app lumberbot-app bot added the bug Something isn't working label May 9, 2024
@meeseeksmachine meeseeksmachine requested a review from kecnry as a code owner May 9, 2024 14:06
@lumberbot-app lumberbot-app bot added testing trivial Only needs one approval instead of two labels May 9, 2024
@meeseeksmachine meeseeksmachine requested a review from bmorris3 as a code owner May 9, 2024 14:06
@lumberbot-app lumberbot-app bot added the no-changelog-entry-needed changelog bot directive label May 9, 2024
@lumberbot-app lumberbot-app bot added the 💤backport-v3.10.x on-merge: backport to v3.10.x label May 9, 2024
@codecov Codecov
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (bf4c599) to head (e43cfb2).
Report is 2 commits behind head on v3.10.x.

Additional details and impacted files 
@@             Coverage Diff             @@
##           v3.10.x    #2866      +/-   ##
===========================================
- Coverage    88.93%   88.91%   -0.03%     
===========================================
  Files          111      111              
  Lines        17165    17163       -2     
===========================================
- Hits         15266    15260       -6     
- Misses        1899     1903       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rosteen
rosteen approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, bot.

@rosteen rosteen merged commit 11c6193 into spacetelescope:v3.10.x May 9, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosteen rosteen rosteen approved these changes

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@pllim pllim Awaiting requested review from pllim pllim is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen is a code owner

Assignees
No one assigned
Labels
bug Something isn't working no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤backport-v3.10.x on-merge: backport to v3.10.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meeseeksmachine @rosteen @pllim