Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Draft PR #3355

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from

Conversation

james-trayford
Copy link

Description

This pull request is to address ...

Fixes #

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

javerbukh and others added 30 commits July 31, 2024 17:27
- Fix sigcube alignment with other cubes [get rid of transpose]
- Add percentile cut option that enables some rough feature isolation without full continuum subtraction
- Protect against cubes w/NaNs
…n-updates-jt

Some more functionality tweaks
@github-actions github-actions bot added documentation Explanation of code and concepts cubeviz testing imviz plugin Label for plugins common to multiple configurations labels Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 41.84100% with 139 lines in your changes missing coverage. Please review.

Project coverage is 88.20%. Comparing base (05e9afb) to head (a12b687).

Files with missing lines Patch % Lines
jdaviz/configs/cubeviz/plugins/cube_listener.py 19.14% 76 Missing ⚠️
jdaviz/configs/cubeviz/plugins/viewers.py 40.67% 35 Missing ⚠️
...configs/cubeviz/plugins/sonify_data/sonify_data.py 65.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3355      +/-   ##
==========================================
- Coverage   88.78%   88.20%   -0.58%     
==========================================
  Files         125      127       +2     
  Lines       19161    19400     +239     
==========================================
+ Hits        17012    17112     +100     
- Misses       2149     2288     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz documentation Explanation of code and concepts imviz plugin Label for plugins common to multiple configurations testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants