-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update deps in environment files #1370
update deps in environment files #1370
Conversation
Hello @BradleySappington, Thank you for updating !
|
@bhilbert4 @mfixstsci Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple general comments:
pyproject.toml references setuptools versions, but those versions are behind the versions in the updated env files. Looks like they've been behind for a while though, and I haven't seen any issues related to it.
rtd_requirements.txt should be brought in line with the updated env files
jwst released 1.12.3 a few days ago. So far the 1.12.x releases are all release candidates, and I did see at least one person who found an obvious bug in 1.12.2.
A new version of yaml??? They've been on v 6.0.0 forever...
@mfixstsci is there a reason setuptools is set to less than 65.5.0? |
According to the handy Blame button, that setuptools line was copied straight from setup.py into pyproject.toml back in April. So I'm assuming those versions were appropriate in April, but probably not now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
The RTD log indicates that sphinx_rtd_theme is installed as a dependency of stsci_rtd_theme.
Update the yml and requirements files with new dependency checks