Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Date Range selection to Query Page #1396

Merged

Conversation

BradleySappington
Copy link
Collaborator

Remove the Date Range Archive page and its functionality completely.
Implement date range picker on main query page so it can be utilized with all other query filters.

@pep8speaks
Copy link

pep8speaks commented Nov 8, 2023

Hello @BradleySappington, Thank you for updating !

Line 1003:5: W503 line break before binary operator
Line 1004:5: W503 line break before binary operator
Line 1005:5: W503 line break before binary operator
Line 1006:5: W503 line break before binary operator
Line 1007:5: W503 line break before binary operator
Line 1008:5: W503 line break before binary operator

Line 410:5: E129 visually indented line with same indent as next logical line
Line 410:17: W503 line break before binary operator
Line 411:21: E117 over-indented
Line 420:56: W504 line break after binary operator
Line 421:5: E129 visually indented line with same indent as next logical line
Line 1402:39: E231 missing whitespace after ':'
Line 1402:60: E231 missing whitespace after ':'

Comment last updated at 2023-11-13 21:25:02 UTC

@BradleySappington BradleySappington self-assigned this Nov 8, 2023
@BradleySappington
Copy link
Collaborator Author

Hello @BradleySappington, Thank you for updating !

Line 1002:25: W504 line break after binary operator
Line 1003:26: W504 line break after binary operator
Line 1004:30: W504 line break after binary operator
Line 1005:38: W504 line break after binary operator
Line 1006:29: W504 line break after binary operator
Line 1007:23: W504 line break after binary operator

Line 410:5: E129 visually indented line with same indent as next logical line
Line 410:17: W503 line break before binary operator
Line 411:21: E117 over-indented
Line 420:56: W504 line break after binary operator
Line 421:5: E129 visually indented line with same indent as next logical line

Comment last updated at 2023-11-08 17:33:50 UTC

PEP8 is enforcing 2 conflicting requirements w503 and w504

@BradleySappington
Copy link
Collaborator Author

@mfixstsci @bhilbert4 - ready for review

@BradleySappington
Copy link
Collaborator Author

BradleySappington commented Nov 8, 2023

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BradleySappington Thanks for your work on this! The changes on the query page look great and I think it cleans up the archive page at the same time.

@BradleySappington BradleySappington merged commit cf2c16a into spacetelescope:develop Nov 13, 2023
6 checks passed
@BradleySappington BradleySappington deleted the date_query branch November 13, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants