Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving monitor outputs used by the server to central storage #1397

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

york-stsci
Copy link
Collaborator

This is the code change part of issue 1395. Before it is merged, all in-use config.json files should be updated to contain a "working" key, whose value should initially be set to the same value as the "outputs" key.

…ed as necessary to use the 'working' directory for interim work
@york-stsci york-stsci self-assigned this Nov 8, 2023
@pep8speaks
Copy link

pep8speaks commented Nov 8, 2023

Hello @york-stsci, Thank you for updating !

Line 994:92: W504 line break after binary operator
Line 995:15: E128 continuation line under-indented for visual indent
Line 1000:111: W504 line break after binary operator
Line 1141:98: W291 trailing whitespace
Line 1142:19: E128 continuation line under-indented for visual indent
Line 1149:98: W291 trailing whitespace
Line 1150:19: E128 continuation line under-indented for visual indent

Comment last updated at 2024-01-22 19:37:42 UTC

Copy link
Collaborator

@BradleySappington BradleySappington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes. Also please keep naming conventions common through all monitors (when appropriate). It looks like working_data_dir and output_data_dir are the most used so would be easiest to stick with that. I did not mark every instance where naming standard wasn't used.

@york-stsci
Copy link
Collaborator Author

@BradleySappington I think I've made all the changes you requested, but I can't figure out how to tell the change request that.

@BradleySappington
Copy link
Collaborator

I approved, I think that should fix it aside from resolving conflicts and making sure the tests pass

@mfixstsci mfixstsci merged commit 550e930 into spacetelescope:develop Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants