-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving monitor outputs used by the server to central storage #1397
Conversation
…ed as necessary to use the 'working' directory for interim work
Hello @york-stsci, Thank you for updating !
Comment last updated at 2024-01-22 19:37:42 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes. Also please keep naming conventions common through all monitors (when appropriate). It looks like working_data_dir
and output_data_dir
are the most used so would be easiest to stick with that. I did not mark every instance where naming standard wasn't used.
@BradleySappington I think I've made all the changes you requested, but I can't figure out how to tell the change request that. |
I approved, I think that should fix it aside from resolving conflicts and making sure the tests pass |
This is the code change part of issue 1395. Before it is merged, all in-use config.json files should be updated to contain a "working" key, whose value should initially be set to the same value as the "outputs" key.