-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jdaviz 4.1 updates #158
base: main
Are you sure you want to change the base?
jdaviz 4.1 updates #158
Conversation
(will need to track down the cause for failing checks - I suspect they're unrelated to this PR and might be due to a change in remote data) |
(assuming change in upstream data)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 93.92% 90.10% -3.83%
==========================================
Files 37 41 +4
Lines 1598 2192 +594
==========================================
+ Hits 1501 1975 +474
- Misses 97 217 +120 ☔ View full report in Codecov by Sentry. |
These test result changes likely came from spacetelescope/jdaviz#3235 We need to track down the cause for the changes in tests and if they are:
Note that the changes are not just caused by changes to the remote data, as the same changes put on top of main are not necessary (see #173) |
This reverts commit 70ea4f4.
plugin-select
and update API hint styling for all select components (data-menu: UI tweaks jdaviz#3310)Waiting for: jdaviz 4.1.1 including spacetelescope/jdaviz#3383 and spacetelescope/jdaviz#3235