Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdaviz 4.1 updates #158

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

jdaviz 4.1 updates #158

wants to merge 9 commits into from

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Dec 4, 2024

Waiting for: jdaviz 4.1.1 including spacetelescope/jdaviz#3383 and spacetelescope/jdaviz#3235

@kecnry kecnry added the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Dec 4, 2024
@kecnry kecnry added this to the 1.1.0 milestone Dec 4, 2024
@kecnry kecnry added waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin and removed waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin labels Jan 7, 2025
@kecnry kecnry removed the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Feb 11, 2025
@kecnry kecnry requested a review from bmorris3 February 11, 2025 14:57
@kecnry kecnry marked this pull request as ready for review February 11, 2025 14:57
@kecnry
Copy link
Member Author

kecnry commented Feb 11, 2025

(will need to track down the cause for failing checks - I suspect they're unrelated to this PR and might be due to a change in remote data)

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (7b78df5) to head (70ea4f4).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   93.92%   90.10%   -3.83%     
==========================================
  Files          37       41       +4     
  Lines        1598     2192     +594     
==========================================
+ Hits         1501     1975     +474     
- Misses         97      217     +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry
Copy link
Member Author

kecnry commented Feb 27, 2025

These test result changes likely came from spacetelescope/jdaviz#3235

We need to track down the cause for the changes in tests and if they are:

  • fixes upstream and therefore expected changes
  • needs an additional fix to jdaviz
  • needs fixes here to account for changes in jdaviz

Note that the changes are not just caused by changes to the remote data, as the same changes put on top of main are not necessary (see #173)

@kecnry kecnry marked this pull request as draft February 27, 2025 14:32
This reverts commit 70ea4f4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants