Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract reference time from data collection #170

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Feb 11, 2025

The reference viewer x-axis is set by TimeScatterView._set_plot_x_axes, which currently requires that you pass in a LightCurve with a reference time in the meta attribute. The function already requires you to pass a DataCollection, which should also have at least one entry with a reference time on its TimeCoordinate.

This PR allows you to set the x-axis without a LightCurve, which is useful if you want to change the axes for an already-loaded light curve in the data collection.

@bmorris3 bmorris3 added this to the 1.1.0 milestone Feb 11, 2025
@bmorris3 bmorris3 requested a review from kecnry February 11, 2025 17:20
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.08%. Comparing base (7b78df5) to head (2bd9c6e).
Report is 55 commits behind head on main.

Files with missing lines Patch % Lines
lcviz/viewers.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   93.92%   90.08%   -3.85%     
==========================================
  Files          37       41       +4     
  Lines        1598     2188     +590     
==========================================
+ Hits         1501     1971     +470     
- Misses         97      217     +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry merged commit 7767aab into spacetelescope:main Feb 19, 2025
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants