ephemeris plugin: custom phase-wrapping #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
force-pushed
the
ephem_wrap_at
branch
from
4467ff3 to
5e3ebb7
Compare
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
kecnry
force-pushed
the
ephem_wrap_at
branch
from
7d77d54 to
1be9fbb
Compare
bmorris3
reviewed
Sep 5, 2023
kecnry
force-pushed
the
ephem_wrap_at
branch
3 times, most recently
from
f220d65 to
df1de4c
Compare
|
Seems like now the phase axis is backwards? I entered wrap at 
|
kecnry
commented
Sep 8, 2023
lcviz/plugins/ephemeris/ephemeris.py
Outdated
Comment on lines
405
to
408
| if event.get('name') == 'wrap_at': | ||
| pvs = self.phase_viewer.state | ||
| delta_phase = event.get('new') - event.get('old') | ||
| pvs.x_min, pvs.x_max = pvs.x_min + delta_phase, pvs.x_max + delta_phase |
There was a problem hiding this comment.
@bmorris3 - I can't reproduce the flipped axis you're seeing. Can you either debug to see what is happening in these lines or send a recording if any intermediate steps are necessary to reproduce?
* whenever the ephemeris (including wrap_at) or the viewer limits are changed, the limits are checked against the full range of data and displays a message and button to reset the x-limits if not all data are shown in the phase-viewer
kecnry
force-pushed
the
ephem_wrap_at
branch
from
b9493e2 to
2d4a74e
Compare
bmorris3
approved these changes
Sep 13, 2023
kecnry
force-pushed
the
ephem_wrap_at
branch
from
2509f94 to
0bb47ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a "phase_wrap" option in the ephemeris plugin along with automatic phase-limits updates
a convenient in-plugin identification when the phase-wrapped data falls outside the viewer x-limits.original in-plugin limits warning
**NOTE**: hint text for the wrapping UI element has been updated slightly since this recording to say "Phased data will encompass the range (1-wrap_at, wrap_at)"Screen.Recording.2023-09-01.at.2.17.29.PM.mov
auto-updating phase-limits
Screen.Recording.2023-09-06.at.9.46.23.AM.mov