-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SDSS APOGEE notebook tutorial #93
Conversation
@snbianco This notebook requires the URL-escaping updates you made to astroquery.mast a few months ago (astropy/astroquery#3080) Do you happen to know when that will be part of a tagged release? My local environment is using I'm not sure how best to proceed - do we need to wait until the astroquery updates are in a tagged release to merge this notebook in? Edit: Building from source in the requirements.txt seems to work! We should update this with a tagged release when we can, but for now I think this is okay! |
Yes, I think that a new tagged release of Astroquery is coming out in the near future! Until then, installing from the GitHub repo should work. |
updating TOC fixing linting for APOGEE notebook more small edits more small linting edits updating APOGEE requirements for astroquery url encoding updating requirements for APOGEE
460542f
to
523235e
Compare
Squashed some commits now that the pipeline is passing, this should be ready to go now! |
This looks good to me. |
I think this is an awesome tutorial notebook with a lot of great information! The plots look really cool, and I like the comparison of 3 different variable stars at the end. I had some comments, but mostly about small things in the notebook text:
|
Thank you @snbianco ! I just pushed an update addressing your comments. |
Thank you @snbianco ! |
The html render looks good to me at a glance, but let us know if you notice any issues @astrojimig! https://spacetelescope.github.io/mast_notebooks/notebooks/SDSS/APOGEE_TESS_tutorial/APOGEE_TESS_tutorial.html |
Adding the notebook tutorial for SDSS APOGEE data, which is now available in ops!
Tagging @ttdu @havok2063 @snbianco for review/visibility