Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WedgeSegmentedDeformableMirror #611

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Mar 5, 2024

This implements a WedgeSegmentedDeformableMirror, suitable for simulating pie-wedge segmented apertures with misalignments per segment. In particular this aperture geometry is used in some exploratory cases for HWO design analyses, which this allows simulating.

Unknown-1

@mperrin mperrin self-assigned this Mar 5, 2024
@mperrin mperrin added the enhancement New feature or request label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 94.64286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.44%. Comparing base (9b9d981) to head (45b739e).
Report is 10 commits behind head on develop.

Files Patch % Lines
poppy/optics.py 93.75% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #611      +/-   ##
===========================================
+ Coverage    74.30%   74.44%   +0.14%     
===========================================
  Files           18       18              
  Lines         6600     6645      +45     
===========================================
+ Hits          4904     4947      +43     
- Misses        1696     1698       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@BradleySappington BradleySappington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the init order comments

@mperrin mperrin merged commit c9b5119 into spacetelescope:develop Mar 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants