Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min pin numexpr #632

Merged

Conversation

BradleySappington
Copy link
Collaborator

@BradleySappington BradleySappington commented Aug 12, 2024

numexpr>=2.9.0 to avoid future bugs per webbpsf issue 902:
spacetelescope/webbpsf#902

Copy link
Collaborator

@mperrin mperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reminding me part of why there wasn't previously a pin for this: numexpr had been left as an optional dependency, not strictly required. I think there is no longer any real need for that; it's no hurdle to install. Just inertia that it had been left as an optional dependency only.

It seems clearly better to have it a required dependency and be able to restrict to a known-good version, versus leave as an optional dependency and maybe an unlucky user has the buggy old version. So I'm 👍 for this.

@BradleySappington BradleySappington merged commit 6c46637 into spacetelescope:develop Aug 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants