Fix an issue with providing astropy Units to calc_datacube #639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue I found with the calc_datacube function, which currently errors if provided wavelengths as astropy Quantities:
This fix makes sure the wavelength is converted to a plain float in units of meters before being saved as a header keyword.
No change is needed in
calc_psf
which already works correctly with units. This fix is just needed forcalc_datacube
which somehow slipped through the cracks for this.