-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up some parts of datamodels._core
#251
Merged
WilliamJamieson
merged 6 commits into
spacetelescope:main
from
WilliamJamieson:refactor/datamodel_core
Oct 6, 2023
Merged
Clean up some parts of datamodels._core
#251
WilliamJamieson
merged 6 commits into
spacetelescope:main
from
WilliamJamieson:refactor/datamodel_core
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
schlafly
reviewed
Jul 26, 2023
WilliamJamieson
force-pushed
the
refactor/datamodel_core
branch
from
July 26, 2023 17:47
cd804eb
to
f75b176
Compare
WilliamJamieson
force-pushed
the
refactor/datamodel_core
branch
2 times, most recently
from
August 3, 2023 17:54
e5f9c63
to
5e26d46
Compare
WilliamJamieson
force-pushed
the
refactor/datamodel_core
branch
3 times, most recently
from
August 16, 2023 16:37
8d68971
to
64c726f
Compare
WilliamJamieson
force-pushed
the
refactor/datamodel_core
branch
3 times, most recently
from
August 22, 2023 14:07
a82146f
to
ca554ea
Compare
WilliamJamieson
force-pushed
the
refactor/datamodel_core
branch
from
August 29, 2023 14:19
ca554ea
to
716d163
Compare
WilliamJamieson
force-pushed
the
refactor/datamodel_core
branch
from
September 6, 2023 15:23
716d163
to
704af2f
Compare
WilliamJamieson
force-pushed
the
refactor/datamodel_core
branch
from
October 5, 2023 14:31
704af2f
to
3b6a964
Compare
nden
reviewed
Oct 5, 2023
braingram
reviewed
Oct 5, 2023
WilliamJamieson
force-pushed
the
refactor/datamodel_core
branch
from
October 6, 2023 19:56
f29ef26
to
8d01b72
Compare
WilliamJamieson
force-pushed
the
refactor/datamodel_core
branch
from
October 6, 2023 19:59
8d01b72
to
73842ed
Compare
braingram
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comment. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-612
Closes #247
This PR cleans up parts of the
datamodels._core
module and adds the ability to properly initialize an "empty" data model, in so far as that if an empty model is created, one can now successfully add information to it. However, the empty model will not validate until it is fully flushed out, so the recommendation is still to use the appropriatemaker_util
.Checklist
CHANGES.rst
under the corresponding subsection