Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some parts of datamodels._core #251

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Jul 26, 2023

Resolves RCAL-612

Closes #247

This PR cleans up parts of the datamodels._core module and adds the ability to properly initialize an "empty" data model, in so far as that if an empty model is created, one can now successfully add information to it. However, the empty model will not validate until it is fully flushed out, so the recommendation is still to use the appropriate maker_util.

Checklist

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 26, 2023 16:39
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_models.py 100.00% <100.00%> (ø)
tests/test_stnode.py 100.00% <100.00%> (ø)
src/roman_datamodels/datamodels/_core.py 93.04% <97.61%> (+1.46%) ⬆️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@WilliamJamieson WilliamJamieson force-pushed the refactor/datamodel_core branch from cd804eb to f75b176 Compare July 26, 2023 17:47
@WilliamJamieson WilliamJamieson force-pushed the refactor/datamodel_core branch 2 times, most recently from e5f9c63 to 5e26d46 Compare August 3, 2023 17:54
@WilliamJamieson WilliamJamieson force-pushed the refactor/datamodel_core branch 3 times, most recently from 8d68971 to 64c726f Compare August 16, 2023 16:37
@WilliamJamieson WilliamJamieson force-pushed the refactor/datamodel_core branch 3 times, most recently from a82146f to ca554ea Compare August 22, 2023 14:07
@WilliamJamieson WilliamJamieson force-pushed the refactor/datamodel_core branch from ca554ea to 716d163 Compare August 29, 2023 14:19
@WilliamJamieson WilliamJamieson force-pushed the refactor/datamodel_core branch from 704af2f to 3b6a964 Compare October 5, 2023 14:31
CHANGES.rst Outdated Show resolved Hide resolved
@nden nden requested a review from braingram October 5, 2023 14:36
@WilliamJamieson WilliamJamieson force-pushed the refactor/datamodel_core branch from f29ef26 to 8d01b72 Compare October 6, 2023 19:56
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comment. LGTM.

@WilliamJamieson WilliamJamieson merged commit 8726378 into spacetelescope:main Oct 6, 2023
14 checks passed
@WilliamJamieson WilliamJamieson deleted the refactor/datamodel_core branch October 6, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix empty DataModel initialization
4 participants