Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-682: Added optional dq array to science raw maker utility and test #282

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

PaulHuwe
Copy link
Collaborator

Resolves RCAL-682

Closes #912

This PR adds optional dq array to science raw maker utility and test.

Checklist

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
src/roman_datamodels/maker_utils/_datamodels.py 95.83% <100.00%> (+0.05%) ⬆️
tests/test_models.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@PaulHuwe PaulHuwe marked this pull request as ready for review October 14, 2023 00:44
@PaulHuwe PaulHuwe requested review from WilliamJamieson and a team as code owners October 14, 2023 00:44
@PaulHuwe PaulHuwe requested a review from schlafly October 17, 2023 13:47
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@PaulHuwe PaulHuwe merged commit 8139173 into spacetelescope:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants