Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #293 #319

Closed
Closed

Conversation

WilliamJamieson
Copy link
Collaborator

Since @ddavis-stsci strongly opposes spacetelescope/romancal#1099 the changes from #293 are pointless and should be removed. This PR reverts those changes.

Checklist

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.70%. Comparing base (087a60d) to head (40987c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   97.56%   96.70%   -0.86%     
==========================================
  Files          30       28       -2     
  Lines        2788     2702      -86     
==========================================
- Hits         2720     2613     -107     
- Misses         68       89      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants