Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for regression tests broken by filename changes #1050

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

This PR fixes regression tests broken by spacetelescope/roman_datamodels#295. In those changes, data models now ensure their meta.filename (if they have one) is set in the written model to the name chosen for the file written. The broken tests wrote the same data model to two different file names and then tried to compare them. This PR simply makes it so that they placed in separate directories so they can have the same file name.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.94%. Comparing base (1a458a0) to head (7844ddc).
Report is 478 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1050   +/-   ##
=======================================
  Coverage   70.94%   70.94%           
=======================================
  Files         105      105           
  Lines        6979     6979           
=======================================
  Hits         4951     4951           
  Misses       2028     2028           
Flag Coverage Δ *Carryforward flag
nightly 63.06% <ø> (ø) Carriedforward from 1a458a0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson WilliamJamieson merged commit 9c04ae5 into spacetelescope:main Dec 18, 2023
35 of 37 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/regtest_filename branch December 18, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants