Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch rad roman_datamodels back to dev #1168

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Apr 3, 2024

Switch rad and roman_datamodels back to dev versions.

Regtests run:
https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/697/
shows 27 errors, many are:

asdf._jsonschema.exceptions.ValidationError: mismatched tags, wanted 'asdf://stsci.edu/datamodels/roman/tags/l2_cal_step-1.0.0', got 'asdf://stsci.edu/datamodels/roman/tags/cal_step-1.0.0'

Likely due to outdated truth files generated before:
#1165
There are other failures:

  • test_tweakreg:TypeError: Input to tweakreg must be a list of DataModels, an association, or an already open ModelContainer containing one or more DataModels
  • test_resample: TypeError: Open requires a filepath, file-like object, or Roman datamodel
  • test_hlp_pipeline: TypeError: Input must be an ASN file or a list of either strings (full path to ASDF files) or Roman datamodels.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Apr 3, 2024
@braingram braingram marked this pull request as ready for review April 3, 2024 19:10
@braingram braingram requested a review from a team as a code owner April 3, 2024 19:10
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.45%. Comparing base (f9517b6) to head (855fe69).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
- Coverage   76.50%   76.45%   -0.05%     
==========================================
  Files         107      107              
  Lines        7081     7096      +15     
==========================================
+ Hits         5417     5425       +8     
- Misses       1664     1671       +7     
Flag Coverage Δ *Carryforward flag
nightly 62.80% <ø> (ø) Carriedforward from f9517b6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly schlafly merged commit b669cba into spacetelescope:main Apr 4, 2024
34 of 37 checks passed
@braingram braingram deleted the dev branch April 5, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants