Group models by obs_id for steps that use grouping

[braingram]

Group by meta.observation.obs_id.

Fixes: #1259

Regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/11281421723
show 5 expected failures like the following:

   {'values_changed': {"root['roman']['meta']['group_id']": {'new_value': '0000201001001001001011010001',
                                                            'old_value': 'roman0000211_1101_1'}}}

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

news fragment change types...

• changes/<PR#>.general.rst: infrastructure or miscellaneous change
• changes/<PR#>.docs.rst
• changes/<PR#>.stpipe.rst
• changes/<PR#>.associations.rst
• changes/<PR#>.scripts.rst
• changes/<PR#>.mosaic_pipeline.rst
• changes/<PR#>.patch_match.rst

steps

• changes/<PR#>.dq_init.rst
• changes/<PR#>.saturation.rst
• changes/<PR#>.refpix.rst
• changes/<PR#>.linearity.rst
• changes/<PR#>.dark_current.rst
• changes/<PR#>.jump_detection.rst
• changes/<PR#>.ramp_fitting.rst
• changes/<PR#>.assign_wcs.rst
• changes/<PR#>.flatfield.rst
• changes/<PR#>.photom.rst
• changes/<PR#>.flux.rst
• changes/<PR#>.source_detection.rst
• changes/<PR#>.tweakreg.rst
• changes/<PR#>.skymatch.rst
• changes/<PR#>.outlier_detection.rst
• changes/<PR#>.resample.rst
• changes/<PR#>.source_catalog.rst

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.15%. Comparing base (e215f87) to head (d139a4b).
Report is 185 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1448   +/-   ##
=======================================
  Coverage   76.15%   76.15%           
=======================================
  Files         115      115           
  Lines        7638     7638           
=======================================
  Hits         5817     5817           
  Misses       1821     1821           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[schlafly]

Thanks, this looks good.

A separate issue, but I hadn't appreciated that we were storing group_id in the files. I guess that's okay? It's not in our schema, so it's an optional added thing. Apparently tweakreg adds it, even for grism data where it's not doing anything and the step gets skipped.

This test seems to imply some special structure is expected in group_id, but I think the test itself is the only thing that assumes that structure so it's probably fine.

romancal/romancal/tweakreg/tests/test_tweakreg.py

Lines 912 to 927 in 1945dad

	img1.meta.observation["program"] = "-program_id1"
	img2.meta.observation["program"] = "-program_id2"
	img1.meta["filename"] = "file1.asdf"
	img2.meta["filename"] = "file2.asdf"
	res = trs.TweakRegStep.call([img1, img2])
	assert len(res.group_names) == 2
	with res:
	for r, i in zip(res, [img1, img2]):
	assert (
	r.meta.group_id.split("-")[1]
	== i.meta.observation.program.split("-")[1]
	)
	res.shelve(r, modify=False)

Anyway, this change looks good and I'll spin some group_id investigation into a separate issue. Can I ask you to handle the okifying? Thanks!

[schlafly]

FWIW, #1450 .

[braingram]

@schlafly I rebased this and resolved the conflict (2 lines in a unit test following #1445).

Any objection if I merge this?

[schlafly]

Go ahead. Please okify afterward, thanks! We've had a lot of other regtest-changing updates in the meantime, so it will require a fresh regtest to okify.

[braingram]

Regression tests for okifying started here: https://github.com/spacetelescope/RegressionTests/actions/runs/11487718465

I'll okify these when they finish.

[braingram]

Results okified, this should be a clean run: https://github.com/spacetelescope/RegressionTests/actions/runs/11488484303