New catalog tests for B16 (aperture photometry, deblending, kernel source detection) #1494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-946
This PR addresses adds new tests of the aperture fluxes, deblending, and kernel source detection to the catalog regression tests. It takes a calibrated L2 file from artifactory as input, and checks that derived output catalogs have aperture fluxes measured. It also runs that calibrated L2 image with a different detection kernel and source deblending. It checks the deblended source catalog to verify that it contains more records than the un-deblended source catalog.
It also updates the regtestdata script to make the new files with deblending and a larger kernel. I uploaded the corresponding new artifacts to artifactory for I&T though the regtest script doesn't currently use those.
These changes were limited to regression tests, and didn't change any public API, so I have not updated any docs / change logs for the moment.
A problem with this PR is that the logs from running pytest currently don't include the relevant "pass" messages. It looks like when webbpsf goes to build a PSF that it does something to the logging from which the logging does not recover; some kind of pytest / stpipe / webbpsf interaction? But the actual tests pass. In a pinch we can probably get the logs to print if we turn off PSF fitting in this source catalog run, though that is a hack.
Tasks
24Q4_B15
(use the latest build if not sure)