Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New catalog tests for B16 (aperture photometry, deblending, kernel source detection) #1494

Closed
wants to merge 8 commits into from

Conversation

schlafly
Copy link
Collaborator

@schlafly schlafly commented Nov 5, 2024

Resolves RCAL-946

This PR addresses adds new tests of the aperture fluxes, deblending, and kernel source detection to the catalog regression tests. It takes a calibrated L2 file from artifactory as input, and checks that derived output catalogs have aperture fluxes measured. It also runs that calibrated L2 image with a different detection kernel and source deblending. It checks the deblended source catalog to verify that it contains more records than the un-deblended source catalog.

It also updates the regtestdata script to make the new files with deblending and a larger kernel. I uploaded the corresponding new artifacts to artifactory for I&T though the regtest script doesn't currently use those.

These changes were limited to regression tests, and didn't change any public API, so I have not updated any docs / change logs for the moment.

A problem with this PR is that the logs from running pytest currently don't include the relevant "pass" messages. It looks like when webbpsf goes to build a PSF that it does something to the logging from which the logging does not recover; some kind of pytest / stpipe / webbpsf interaction? But the actual tests pass. In a pinch we can probably get the logs to print if we turn off PSF fitting in this source catalog run, though that is a hack.

Tasks

@schlafly schlafly added this to the 25Q1_B16 milestone Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.19%. Comparing base (e967257) to head (ce7fa30).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1494   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files         115      115           
  Lines        7626     7626           
=======================================
  Hits         5811     5811           
  Misses       1815     1815           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator Author

I merged this work into Larry's multiband catalog PR; closing.

@schlafly schlafly closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant