Reverting edge case to previous logic

spacetelescope · Feb 6, 2025 · 68118a2 · 68118a2
1 parent 6e252e2
commit 68118a2
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/src/stcal/jump/twopoint_difference.py b/src/stcal/jump/twopoint_difference.py
@@ -288,19 +288,16 @@ def find_crs_old(
             del clipped_diffs
             gdq[:, 1:] |= jump_mask * np.uint8(jump_flag)
 
-            # Note: the code below originally did something very different
-            # from what the comment below says.  Please check.
-            # 
             # if grp is all jump set to do not use
             for integ in range(nints):
                 for grp in range(ngrps):
                     if np.all(gdq[integ, grp] & (jump_flag | dnu_flag) != 0):
-                        gdq[integ, grp] |= dnu_flag
+                        # The line below matches the comment above, but not the
+                        # old logic.  Leaving it for now.
+                        #gdq[integ, grp] |= dnu_flag
 
-                    #if np.all(np.bitwise_or(np.bitwise_and(gdq[integ, grp, :, :], jump_flag),
-                    #                        np.bitwise_and(gdq[integ, grp, :, :], dnu_flag))):
-                    #    jumpy, jumpx = np.where(gdq[integ, grp, :, :] == jump_flag)
-                    #    gdq[integ, grp, jumpy, jumpx] = 0
+                        jump_only = gdq[integ, grp, :, :] == jump_flag
+                        gdq[integ, grp][jump_only] = 0
 
             warnings.resetwarnings()
         else:  # There are not enough groups for sigma clipping