Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Ubuntu 24.04 image in CI #54

Merged
merged 9 commits into from
Aug 9, 2024
Merged

Build Ubuntu 24.04 image in CI #54

merged 9 commits into from
Aug 9, 2024

Conversation

adamjstewart
Copy link
Member

Missed one very important line of code.

@alalazo alalazo self-assigned this Aug 6, 2024
@adamjstewart
Copy link
Member Author

@alalazo I'm a bit stuck on this. I thought ENV would pass env vars to the next RUN command and make them available. Can you double check what I did and see what I'm missing? It's still using the system python3 for some reason.

@adamjstewart adamjstewart requested a review from haampie August 7, 2024 10:59
@adamjstewart
Copy link
Member Author

Docker logic is based on https://pythonspeed.com/articles/activate-virtualenv-dockerfile/

@alalazo alalazo merged commit 903932a into main Aug 9, 2024
11 checks passed
@alalazo alalazo deleted the ubuntu-24-ci branch August 9, 2024 03:34
@adamjstewart adamjstewart mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalazo alalazo alalazo approved these changes

@haampie haampie Awaiting requested review from haampie

Assignees

@alalazo alalazo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjstewart @alalazo