feat: Add --verbose flag
#691
Conversation
for more information, see https://pre-commit.ci
|
@carlosm27 is attempting to deploy a commit to the sparckles Team on Vercel. A member of the Team first needs to authorize it. |
CodSpeed Performance ReportMerging #691 will improve performances by 11.55%Comparing Summary
Benchmarks breakdown
|
| INFO_APP = 55 # Level number, higher than CRITICAL (50) | ||
| logging.addLevelName(INFO_APP, "INFO_APP") # Add level name | ||
|
|
||
|
|
||
| def info_app(self, message, *args, **kwargs): | ||
| self._log(INFO_APP, message, args, kwargs) | ||
|
|
||
|
|
||
| logging.Logger.info_app = info_app # Add method to Logger class | ||
|
|
||
| logging.INFO_APP = INFO_APP # Optional - for convenience | ||
|
|
||
| logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
Hey @carlosm27 👋
Thank you for the PR 😄 Can you please explain what the INFO_APP parameter does?
There was a problem hiding this comment.
Hey @sansyrox it creates a new log level because with the info level shows also the logs from Actix too. But, I just notice in the Logger documentation that it doesn't advice creating new logs levels because it can create conflicts with other libraries. So, I will continue working on this and making updates to receive their review.
There was a problem hiding this comment.
Hey @carlosm27 any further updates to this? Let us know if you are stuck on the issue
sansyrox
force-pushed
the
main
branch
5 times, most recently
from
07f28de to
0b766c9
Compare
Description
This PR add the
--verboseflag and add the log levelInfo APPto hide the logging messages from Actix.With the
--verboseflag:This PR fixes #611