feat: control dev mode with env var #877

VishnuSanal · 2024-07-01T09:00:22Z

Description

This PR fixes #62

vercel · 2024-07-01T09:00:27Z

@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

codspeed-hq · 2024-07-01T09:06:28Z

CodSpeed Performance Report

Merging #877 will not alter performance

_{Comparing VishnuSanal:hot-reload-env-var (8f3c442) with main (7b025a3)}

Summary

✅ 110 untouched benchmarks

robyn/cli.py

robyn/__init__.py

docs_src/src/pages/documentation/api_reference/robyn_env.mdx

sansyrox · 2024-07-05T14:31:19Z

robyn/argument_parser.py

@@ -23,7 +23,7 @@ def __init__(self) -> None:
            "--dev",
            dest="dev",
            action="store_true",
-            default=False,
+            default=None,


Let's document this decision?

@sansyrox It will be defaulted to false if an environment variable is not found. (since the fallback value to os.getenv on cli#run is false) Should we still document it?

@VishnuSanal , I want you to document the decision that the env variable will have a priority over the cli flag.

I believe we should prioritise cli flag over the env variable.

sansyrox · 2024-07-05T15:38:30Z

Also, could you add a way to control the dev mode in app.start(debug=True)

VishnuSanal · 2024-07-05T16:03:04Z

Also, could you add a way to control the dev mode in app.start(debug=True)

the decision to turn on/off the dev mode would have been made before we reach robyn#start. adding the debug param would be redundant as of now. or, to implement this then would require the restarting of server as mentioned here. can we move this to be a new issue?

sansyrox · 2024-07-05T16:31:55Z

the decision to turn on/off the dev mode would have been made before we reach robyn#start

And why is that? I thought you were implementing python app.py --dev And even if it is robyn app.py Why is it being invoked before start?

VishnuSanal · 2024-07-05T17:09:04Z

the decision to turn on/off the dev mode would have been made before we reach robyn#start

And why is that?

what I meant with "the decision to turn on/off the dev mode would have been made before we reach robyn#start" is that that the control flow reaches robyn#start from cli#run => cli#start_dev_server or cli#run => cli#start_app_normally.

I thought you were implementing python app.py --dev And even if it is robyn app.py Why is it being invoked before start?

I didn't get you? yeah, I am implementing the toggle for dev mode from env vars; but, in both cases, wouldn't the decision to switch to whether to start app normally or to start the dev server would have been made before the init?

robyn/__init__.py

robyn/cli.py

robyn/__init__.py

for more information, see https://pre-commit.ci

sansyrox · 2024-07-09T15:07:10Z

@VishnuSanal , updated the PR. Do have a look.

sansyrox · 2024-07-09T16:34:33Z

@VishnuSanal , could you do a self review/review on my changes? And then I can do a final review 😄

VishnuSanal

it doesn't work as expected in my testing.

(.venv) RobynApp $ python3 app.py
INFO:robyn.logger:SERVER IS RUNNING IN VERBOSE/DEBUG MODE. Set --log-level to WARN to run in production mode.
INFO:robyn.logger:Added route HttpMethod.GET /
INFO:robyn.logger:Robyn version: 0.56.1
INFO:robyn.logger:Starting server at http://0.0.0.0:8080
INFO:actix_server.builder:starting 1 workers
INFO:actix_server.server:Actix runtime found; starting in Actix runtime
^CINFO:actix_server.server:SIGINT received; starting forced shutdown
INFO:actix_server.worker:shutting down idle worker
INFO:actix_server.accept:accept thread stopped
Aborted (core dumped)

(.venv) RobynApp $ robyn app.py
Starting dev server...
Reloading /home/vishnu/Robyn/RobynApp/app.py...
INFO:robyn.logger:SERVER IS RUNNING IN VERBOSE/DEBUG MODE. Set --log-level to WARN to run in production mode.
INFO:robyn.logger:Added route HttpMethod.GET /
INFO:robyn.logger:Robyn version: 0.56.1
INFO:robyn.logger:Starting server at http://0.0.0.0:8080
INFO:actix_server.builder:starting 1 workers
INFO:actix_server.server:Actix runtime found; starting in Actix runtime
^CINFO:actix_server.server:SIGINT received; starting forced shutdown
INFO:actix_server.accept:accept thread stopped
INFO:actix_server.worker:shutting down idle worker

(.venv) RobynApp $ cat robyn.env
ROBYN_DEV_MODE=True

sansyrox · 2024-07-10T09:55:56Z

What is unexpected here @VishnuSanal ?

VishnuSanal · 2024-07-10T10:15:46Z

What is unexpected here @VishnuSanal ?

I have the environemnt variable set to true, but no warning is shown when running python3 app.py (CMIIW).

sansyrox · 2024-07-10T15:42:49Z

@VishnuSanal , is it actually running in dev mode?

VishnuSanal · 2024-07-10T15:53:30Z

@VishnuSanal , is it actually running in dev mode?

it wasn't actually running in dev mode + the warning wasn't being shown, even after setting the env var. Please refer to the logs attached.

(.venv) RobynApp $ python3 app.py
INFO:robyn.logger:SERVER IS RUNNING IN VERBOSE/DEBUG MODE. Set --log-level to WARN to run in production mode.
INFO:robyn.logger:Added route HttpMethod.GET /
INFO:robyn.logger:Robyn version: 0.56.1
INFO:robyn.logger:Starting server at http://0.0.0.0:8080
INFO:actix_server.builder:starting 1 workers
INFO:actix_server.server:Actix runtime found; starting in Actix runtime
^CINFO:actix_server.server:SIGINT received; starting forced shutdown
INFO:actix_server.worker:shutting down idle worker
INFO:actix_server.accept:accept thread stopped
Aborted (core dumped)

(.venv) RobynApp $ robyn app.py
Starting dev server...
Reloading /home/vishnu/Robyn/RobynApp/app.py...
INFO:robyn.logger:SERVER IS RUNNING IN VERBOSE/DEBUG MODE. Set --log-level to WARN to run in production mode.
INFO:robyn.logger:Added route HttpMethod.GET /
INFO:robyn.logger:Robyn version: 0.56.1
INFO:robyn.logger:Starting server at http://0.0.0.0:8080
INFO:actix_server.builder:starting 1 workers
INFO:actix_server.server:Actix runtime found; starting in Actix runtime
^CINFO:actix_server.server:SIGINT received; starting forced shutdown
INFO:actix_server.accept:accept thread stopped
INFO:actix_server.worker:shutting down idle worker

(.venv) RobynApp $ cat robyn.env
ROBYN_DEV_MODE=True

sansyrox · 2024-07-15T14:40:03Z

@VishnuSanal , have a look once.

for more information, see https://pre-commit.ci

…oad-env-var # Conflicts: # robyn/reloader.py

VishnuSanal · 2024-07-15T16:22:12Z

yeps, works as expected! attaching the logs for reference.

(.venv) testing_application $ cat robyn.env
ROBYN_DEV_MODE=True

(.venv) testing_application $ python3 app.py
Ignoring ROBYN_DEV_MODE environment variable. Dev mode is not supported in the python wrapper.
Dev mode is not supported in the python wrapper. Please use the Robyn CLI. e.g. python3 -m robyn app.py

(.venv) testing_application $ robyn app.py
Starting dev server...
Reloading the server
argumens
INFO:robyn.logger:SERVER IS RUNNING IN VERBOSE/DEBUG MODE. Set --log-level to WARN to run in production mode.
INFO:robyn.logger:Added route HttpMethod.GET /
INFO:robyn.logger:Robyn version: 0.56.1
INFO:robyn.logger:Starting server at http://0.0.0.0:8080
INFO:actix_server.builder:starting 1 workers
INFO:actix_server.server:Actix runtime found; starting in Actix runtime
^CINFO:actix_server.server:SIGINT received; starting forced shutdown
INFO:actix_server.worker:shutting down idle worker
INFO:actix_server.accept:accept thread stopped

(.venv) testing_application $ cat robyn.env
ROBYN_DEV_MODE=False

(.venv) testing_application $ python3 app.py
INFO:robyn.logger:SERVER IS RUNNING IN VERBOSE/DEBUG MODE. Set --log-level to WARN to run in production mode.
INFO:robyn.logger:Added route HttpMethod.GET /
INFO:robyn.logger:Robyn version: 0.56.1
INFO:robyn.logger:Starting server at http://0.0.0.0:8080
INFO:actix_server.builder:starting 1 workers
INFO:actix_server.server:Actix runtime found; starting in Actix runtime
^CINFO:actix_server.server:SIGINT received; starting forced shutdown
INFO:actix_server.worker:shutting down idle worker
INFO:actix_server.accept:accept thread stopped
Aborted (core dumped)

(.venv) testing_application $ robyn app.py
INFO:robyn.logger:SERVER IS RUNNING IN VERBOSE/DEBUG MODE. Set --log-level to WARN to run in production mode.
INFO:robyn.logger:Added route HttpMethod.GET /
INFO:robyn.logger:Robyn version: 0.56.1
INFO:robyn.logger:Starting server at http://0.0.0.0:8080
INFO:actix_server.builder:starting 1 workers
INFO:actix_server.server:Actix runtime found; starting in Actix runtime
^CINFO:actix_server.server:SIGINT received; starting forced shutdown
INFO:actix_server.worker:shutting down idle worker
INFO:actix_server.accept:accept thread stopped

robyn/__init__.py

sansyrox

LGTM 😄

[sparckles#62] feat: control dev mode with env var

1c8e670

sansyrox reviewed Jul 1, 2024

View reviewed changes

robyn/cli.py Outdated Show resolved Hide resolved

sansyrox reviewed Jul 1, 2024

View reviewed changes

robyn/__init__.py Show resolved Hide resolved

VishnuSanal added 3 commits July 4, 2024 21:34

Merge branch 'refs/heads/main' into hot-reload-env-var

a7d404b

add load_vars back to __init__

6c580bc

docs: add docs for ROBYN_DEV_MODE

ff5b8dd

sansyrox reviewed Jul 4, 2024

View reviewed changes

docs_src/src/pages/documentation/api_reference/robyn_env.mdx Show resolved Hide resolved

fix: give priority to CLI arg

b927f04

sansyrox reviewed Jul 5, 2024

View reviewed changes

fix: path when running as a module

033a376

VishnuSanal requested a review from sansyrox July 6, 2024 16:02

give heads up when running as a module + fix bool issue ;__;

ca7c361

sansyrox reviewed Jul 6, 2024

View reviewed changes

robyn/__init__.py Outdated Show resolved Hide resolved

sansyrox reviewed Jul 6, 2024

View reviewed changes

robyn/cli.py Show resolved Hide resolved

sansyrox reviewed Jul 8, 2024

View reviewed changes

robyn/__init__.py Outdated Show resolved Hide resolved

sansyrox and others added 2 commits July 9, 2024 16:06

update code

394024f

[pre-commit.ci] auto fixes from pre-commit.com hooks

f6b088c

for more information, see https://pre-commit.ci

VishnuSanal commented Jul 10, 2024

View reviewed changes

update

606588a

sansyrox force-pushed the hot-reload-env-var branch from f6b088c to 606588a Compare July 15, 2024 14:39

update

47da13f

sansyrox force-pushed the hot-reload-env-var branch from 16faef2 to 47da13f Compare July 15, 2024 15:02

pre-commit-ci bot and others added 2 commits July 15, 2024 15:04

[pre-commit.ci] auto fixes from pre-commit.com hooks

58338de

for more information, see https://pre-commit.ci

Merge remote-tracking branch 'origin/hot-reload-env-var' into hot-rel…

76a6afe

…oad-env-var # Conflicts: # robyn/reloader.py

chore: cleanup

0d2556d

VishnuSanal commented Jul 17, 2024

View reviewed changes

robyn/__init__.py Show resolved Hide resolved

chore: fix ci

8f3c442

sansyrox approved these changes Jul 19, 2024

View reviewed changes

sansyrox merged commit aac58bb into sparckles:main Jul 19, 2024
58 of 59 checks passed

VishnuSanal deleted the hot-reload-env-var branch August 22, 2024 06:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: control dev mode with env var #877

feat: control dev mode with env var #877

VishnuSanal commented Jul 1, 2024

vercel bot commented Jul 1, 2024

codspeed-hq bot commented Jul 1, 2024 •

edited

Loading

sansyrox Jul 5, 2024

VishnuSanal Jul 5, 2024

sansyrox Jul 6, 2024

sansyrox commented Jul 5, 2024

VishnuSanal commented Jul 5, 2024

sansyrox commented Jul 5, 2024 •

edited

Loading

VishnuSanal commented Jul 5, 2024

sansyrox commented Jul 9, 2024

sansyrox commented Jul 9, 2024

VishnuSanal left a comment •

edited

Loading

sansyrox commented Jul 10, 2024

VishnuSanal commented Jul 10, 2024

sansyrox commented Jul 10, 2024

VishnuSanal commented Jul 10, 2024

sansyrox commented Jul 15, 2024

VishnuSanal commented Jul 15, 2024

sansyrox left a comment

feat: control dev mode with env var #877

feat: control dev mode with env var #877

Conversation

VishnuSanal commented Jul 1, 2024

vercel bot commented Jul 1, 2024

codspeed-hq bot commented Jul 1, 2024 • edited Loading

CodSpeed Performance Report

Merging #877 will not alter performance

Summary

sansyrox Jul 5, 2024

Choose a reason for hiding this comment

VishnuSanal Jul 5, 2024

Choose a reason for hiding this comment

sansyrox Jul 6, 2024

Choose a reason for hiding this comment

sansyrox commented Jul 5, 2024

VishnuSanal commented Jul 5, 2024

sansyrox commented Jul 5, 2024 • edited Loading

VishnuSanal commented Jul 5, 2024

sansyrox commented Jul 9, 2024

sansyrox commented Jul 9, 2024

VishnuSanal left a comment • edited Loading

Choose a reason for hiding this comment

sansyrox commented Jul 10, 2024

VishnuSanal commented Jul 10, 2024

sansyrox commented Jul 10, 2024

VishnuSanal commented Jul 10, 2024

sansyrox commented Jul 15, 2024

VishnuSanal commented Jul 15, 2024

sansyrox left a comment

Choose a reason for hiding this comment

codspeed-hq bot commented Jul 1, 2024 •

edited

Loading

sansyrox commented Jul 5, 2024 •

edited

Loading

VishnuSanal left a comment •

edited

Loading