Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: lecture sync error due to missing old_code #165

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Fix: lecture sync error due to missing old_code #165

merged 3 commits into from
Jan 12, 2025

Conversation

aariprom
Copy link
Contributor

@aariprom aariprom commented Jan 12, 2025 •
edited
Loading

개요

2025년에 신설되어 OLD_NO가 없는 lecture에 대해, sync 과정에서 발생하는 문제를 수정하였습니다.

수정 사항

  • old_code 대신 new_code를 기준으로 courseMap을 작성하도록 수정
  • department code를 OLD_NO 대신 SUBJECT_NO에서 추출하도록 수정
  • OLD_NO(old_code) 대신 SUBJECT_NO(new_code)를 기준으로 foundLecture를 판단하도록 수정

테스트

  • 기존에 문제가 발생했던 DHS.32201, HSS.32201, AE.94307, AE.94308이 정상적으로 검색 및 시간표에 등록되는 것을 로컬 환경에서 확인하였습니다.
  • sync 과정에서 error가 발생하지 않는 것을 로컬 환경에서 확인하였습니다.

@aariprom aariprom linked an issue Jan 12, 2025 that may be closed by this pull request
학사DB 동기화 로직 수정 #163
Closed
LarryKwon
LarryKwon approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@LarryKwon LarryKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LarryKwon LarryKwon merged commit 8c319ca into dev Jan 12, 2025
3 of 4 checks passed
@LarryKwon LarryKwon deleted the issue/163/fix-lecture-sync branch January 12, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarryKwon LarryKwon LarryKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

학사DB 동기화 로직 수정
2 participants
@aariprom @LarryKwon