Merge pull request #535 from sparcs-kaist/#534-fix-gettaxifare-endpoint

#534 [Bug] 네이버 지도 API Credentials가 존재하지 않을 때의 잘못된 동작
sparcs-kaist · Aug 20, 2024 · 5ca7315 · 5ca7315
2 parents ed177db + bdb4889
commit 5ca7315
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/modules/fare.js b/src/modules/fare.js
@@ -32,8 +32,8 @@ const scaledTime = (time) => {
 const initializeDatabase = async () => {
   try {
     if (
-      naverMapApi["X-NCP-APIGW-API-KEY"] === undefined ||
-      naverMapApi["X-NCP-APIGW-API-KEY-ID"] === undefined
+      !naverMapApi["X-NCP-APIGW-API-KEY"] ||
+      !naverMapApi["X-NCP-APIGW-API-KEY-ID"]
     ) {
       logger.error(
         "There is no credential for Naver Map. Taxi Fare functions are disabled."
@@ -126,8 +126,8 @@ const initializeDatabase = async () => {
  */
 const updateTaxiFare = async (sTime, isMajor) => {
   if (
-    naverMapApi["X-NCP-APIGW-API-KEY"] === undefined ||
-    naverMapApi["X-NCP-APIGW-API-KEY-ID"] === undefined
+    !naverMapApi["X-NCP-APIGW-API-KEY"] ||
+    !naverMapApi["X-NCP-APIGW-API-KEY-ID"]
   ) {
     logger.error(
       "There is no credential for Naver Map. Taxi Fare functions are disabled."
@@ -169,8 +169,8 @@ const updateTaxiFare = async (sTime, isMajor) => {
  */
 const callTaxiFare = async (from, to) => {
   if (
-    naverMapApi["X-NCP-APIGW-API-KEY"] === undefined ||
-    naverMapApi["X-NCP-APIGW-API-KEY-ID"] === undefined
+    !naverMapApi["X-NCP-APIGW-API-KEY"] ||
+    !naverMapApi["X-NCP-APIGW-API-KEY-ID"]
   ) {
     logger.error(
       "There is no credential for Naver Map. Taxi Fare functions are disabled."

diff --git a/src/services/fare.js b/src/services/fare.js
@@ -21,8 +21,8 @@ const naverMapApi = {
 const getTaxiFareHandler = async (req, res) => {
   try {
     if (
-      naverMapApi["X-NCP-APIGW-API-KEY"] === false ||
-      naverMapApi["X-NCP-APIGW-API-KEY-ID"] === false
+      !naverMapApi["X-NCP-APIGW-API-KEY"] ||
+      !naverMapApi["X-NCP-APIGW-API-KEY-ID"]
     ) {
       return res.status(503).json({
         error: "fare/getTaxiFareHandler: Naver Map API credential not found",