#573 2025 봄 이벤트 간접 초대 기능 추가 #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
kmc7468
requested changes
Feb 19, 2025
src/lottery/services/globalState.js
Outdated
Comment on lines
140
to
152
| let currentInviter = inviterStatus; | ||
| while (currentInviter?.inviter) { | ||
| const higherInviter = await eventStatusModel | ||
| .findOne({ userId: currentInviter.inviter }) | ||
| .lean(); | ||
| if (!higherInviter) break; | ||
|
|
||
| await contracts.completeIndirectEventSharingQuest( | ||
| higherInviter.userId, | ||
| req.timestamp | ||
| ); | ||
| currentInviter = higherInviter; | ||
| } |
There was a problem hiding this comment.
ancestor들의 object id를 먼저 다 구해서 배열에 저장하고, Promise.all 을 이용해서 일괄적으로 퀘스트 완료 처리를 하면 어떨까요? completeQuest 내부에서 DB에 자주 접근해서, 이렇게 순차적으로 처리하면 성능 병목이 발생할 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
다단계 시스템을 추가했습니다
It closes #573