chore: use wordpress eslint plugin #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonoliver
approved these changes
Oct 31, 2023
- install wordpress eslint plugin - use recommended WP rules (minus formatting) - include type definitions in generator
dustin-jw
force-pushed
the
chore--wordpress-eslint-plugin
branch
from
dc71c03 to
9407056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #127
To Validate
npm cinpm run generate:custom-blocks-plugin, thennpm run generate:custom-blockto create a test block that we can check our linting rules againstnpm run lint:jsand confirm that it runs successfully (it should report an error if yourview.jshas aconsole.logstatement)npm run lint:jsreports the expected errors