167 exp link checker #171
Closed
167 exp link checker #171
+46
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmmh... this is basically changing every link from the routed slug to the local filename. I'm not a fan of this. Quite the opposite, I would make sure all links are in the agnostic This makes easier to maintain it and I guess it's better for SEO too. |
|
@stickgrinder All drawbacks are resolved by the enhanced version of markdown-link-validator, we can discard this PR and test #173 instead. |
|
This is obsolete. Closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple addition of markdown-link-validator to Makefile using npx and some fixes to markdown files because of compatibility issues with original validator (ie. it not supports absolute local path
/path/to/local/file.mdor local path without.mdextension, see #167).