fix: remove legacy check to ensure variables

[paolomainardi]

PR Type

Enhancement

---

Description

• Removed legacy validation check by commenting out the ensure_deploy_variables function call in the deployment script
• This change simplifies the deployment process by removing redundant variable validation

---

Changes walkthrough 📝

	Relevant files
Enhancement	deploy Remove legacy deployment variables validation check            scripts/deploy Commented out the ensure_deploy_variables function call +1/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[sparkfabrik-ai-bot]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 Security concerns Configuration validation: Removing the ensure_deploy_variables check could potentially allow deployments to proceed with missing or invalid configuration values, which may lead to security misconfigurations in the Kubernetes deployment. The validation of security-critical variables should be verified to still occur elsewhere in the codebase.

⚡ Recommended focus areas for review Missing Validation Commenting out ensure_deploy_variables without replacement could lead to undefined deployment variables being used. Need to verify that all required variables are still properly validated elsewhere.

[sparkfabrik-ai-bot]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Typo	Fix spelling error in error message to improve user experience Fix the typo in the error message where "directiry" should be "directory" scripts/deploy [26] -echo "Missing kubernetes configuration files, not existing directiry: ${DEPLOY_CONF_DIR}." +echo "Missing kubernetes configuration files, not existing directory: ${DEPLOY_CONF_DIR}." Suggestion importance[1-10]: 3 Why: The suggestion correctly identifies and fixes a typo ('directiry' to 'directory') in the error message. While this improves clarity, it's a minor cosmetic fix with minimal impact on functionality.	3

[Monska85]

LGTM 👍