Skip to content

Commit

Permalink
Remove old checksum verification checks for dmg archives (#2568)
Browse files Browse the repository at this point in the history
These are antiquated checks and they can take considerable time to perform. HTTPS or EdDSA verification will validate that an archive isn't corrupt.
  • Loading branch information
zorgiepoo committed May 25, 2024
1 parent 61054c7 commit 444a537
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion Autoupdate/SUDiskImageUnarchiver.m
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ - (void)extractDMGWithNotifier:(SUUnarchiverNotifier *)notifier SPU_OBJC_DIRECT

NSData *promptData = [NSData dataWithBytes:"yes\n" length:4];

NSMutableArray *arguments = [@[@"attach", _archivePath, @"-mountpoint", mountPoint, /*@"-noverify",*/ @"-nobrowse", @"-noautoopen"] mutableCopy];
// Finder doesn't verify disk images anymore beyond the code signing signature (if available)
// Opt out of the old CRC checksum checks
NSMutableArray *arguments = [@[@"attach", _archivePath, @"-mountpoint", mountPoint, @"-noverify", @"-nobrowse", @"-noautoopen"] mutableCopy];

if (_decryptionPassword) {
NSMutableData *passwordData = [[_decryptionPassword dataUsingEncoding:NSUTF8StringEncoding] mutableCopy];
Expand Down

0 comments on commit 444a537

Please sign in to comment.