Skip preflight update check in sparkle-cli if user is root (#2645)

sparkle-project · Oct 12, 2024 · f3dc125 · f3dc125
1 parent 544c642
commit f3dc125
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/sparkle-cli/SPUCommandLineDriver.m b/sparkle-cli/SPUCommandLineDriver.m
@@ -139,7 +139,17 @@ - (BOOL)updater:(SPUUpdater *)updater mayPerformUpdateCheck:(SPUUpdateCheck)upda
     switch (updateCheck) {
         case SPUUpdateCheckUpdates:
         case SPUUpdateCheckUpdatesInBackground:
-            if (_interactive || !SPUSystemNeedsAuthorizationAccessForBundlePath(_updater.hostBundle.bundlePath)) {
+        {
+            if (_interactive) {
+                return YES;
+            }
+
+            BOOL rootUser = (geteuid() == 0);
+            if (rootUser) {
+                return YES;
+            }
+
+            if (!SPUSystemNeedsAuthorizationAccessForBundlePath(_updater.hostBundle.bundlePath)) {
                 return YES;
             }
 
@@ -148,6 +158,7 @@ - (BOOL)updater:(SPUUpdater *)updater mayPerformUpdateCheck:(SPUUpdateCheck)upda
             }
 
             return NO;
+        }
         case SPUUpdateCheckUpdateInformation:
             return YES;
     }