Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip extracting auxiliary files and improve extraction progress for disk images #2569

Merged
merged 13 commits into from
May 27, 2024

Conversation

zorgiepoo
Copy link
Member

  • Skip extracting auxiliary files from disk images
  • Improve reporting extraction progress from disk images by monitoring how many files are copied
  • Improve progress reporting in sparkle-cli slightly

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Added unit tests for extracting more disk image files (with auxiliary files or pkg file), and tested downloading/extracting disk image files with a custom app, including a disk image containing a pkg file.

macOS version tested: 14.5 (23F79)

@zorgiepoo zorgiepoo added this to the 2.7 milestone May 27, 2024
@zorgiepoo zorgiepoo changed the title Skip extracting auxiliary files and improve extraction progress from dmg Skip extracting auxiliary files and improve extraction progress for disk images May 27, 2024
@zorgiepoo zorgiepoo merged commit 27cf3b3 into 2.x May 27, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the improve-dmg-progress-extraction branch May 27, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant