Update hebrew locale

[ShlomoCode]

I am a native speaker

Fixes # (issue)

Misc Checklist

• My change requires a documentation update on Sparkle's website repository
• My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

• Sparkle Test App
• Unit Tests
• My own app
• Other (please specify)

(Describe all the cases that were tested)

macOS version tested: 14.5

[zorgiepoo]

GitHub won't allow me to merge this because it is still a draft.

[ShlomoCode]

Yes, I made a few quick fixes, in the next few days I'll finish it and get it out of draft mode

[ShlomoCode]

@zorgiepoo It's ready to merge

[zorgiepoo]

The first %1$ should be %1$@ I think.

[zorgiepoo]

Also the second one might be wrong too.

[ShlomoCode]

It seems to me that it is wrong only in GitHub/VSCode's display which is LTR, and therefore causes a distorted display of mixed Hebrew (RTL) and English (LTR) text
When I copy the line to a div that is set to RTL, it displays properly: https://jsitor.com/WNpswH34x

[zorgiepoo]

Is this how you expect it to look like? It's best to check how the strings look at runtime in an app. I reset the defaults of the Sparkle Test App with defaults delete org.sparkle-project.SparkleTestApp and launched the app twice to get the permission prompt.

[ShlomoCode]

Yes it looks great
I have now also tested the all flow with Sparkle Test App and the format is valid, there are some minor RTL issues but I will file a separate issue on that

[zorgiepoo]

Formatter token looks like it may be wrong here too.

[ShlomoCode]

Same as #2573 (comment)

[zorgiepoo]

The Hebrew localization is not currently enabled in SUUpdatePermissionPrompt.xib. It can be enabled in Xcode's File inspector for that file.

[ShlomoCode]

I have activated the SUUpdatePermissionPrompt file now

[zorgiepoo]

Thank you. I'll merge after the CI automation is done verifying the changes.

(One note: it's easier for me to review/track changes if you don't force push commits on the pull request branch. Also typically people create a separate branch when merging changes so they can keep their 2.x branch in sync. Edit: never mind, I see GitHub provides me of a way of comparing different revisions still. Oh well).

[ShlomoCode]

Would you like to wait for me to add RLM tags or should we do it in a new PR?

[zorgiepoo]

Let's separate it and wait until this one merges.