Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize system profile display keys #2577

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

zorgiepoo
Copy link
Member

Related to #2575

Allows system profile table keys to be localized.

Check 94440a4 as an example placeholder of how to localize these fields for another language.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested running test app in English and in another language by manually adjusting the localized values.

macOS version tested: 14.5 (23F79)

@zorgiepoo zorgiepoo added this to the 2.7 milestone Jun 7, 2024
@zorgiepoo zorgiepoo merged commit 2a48c17 into 2.x Jun 7, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the internationalize-system-profile branch June 7, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant